-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-677: chore: separate device filtering from vgmanager in lsblk package #415
OCPVE-677: chore: separate device filtering from vgmanager in lsblk package #415
Conversation
@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 54.07% 54.11% +0.03%
==========================================
Files 27 27
Lines 2358 2360 +2
==========================================
+ Hits 1275 1277 +2
Misses 997 997
Partials 86 86
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e66ba95
to
3407add
Compare
/lgtm |
/test lvm-operator-e2e-aws-sno |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Part of vgmanager Refactor.
Refactored vgmanager to use the
lsblk
andfilter
package for discovering and filtering block devices. This change involves updating the types, function calls, and unit tests to use the types and functions provided by the lsblk package.