-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-677: chore: separate lvmd package from vgmanager #411
OCPVE-677: chore: separate lvmd package from vgmanager #411
Conversation
@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 53.95% 52.67% -1.29%
==========================================
Files 27 27
Lines 2376 2561 +185
==========================================
+ Hits 1282 1349 +67
- Misses 1007 1127 +120
+ Partials 87 85 -2
|
47eb80c
to
d5ecced
Compare
d5ecced
to
30d78ab
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Part of vgmanager refactoring. This refactors the lvmd configuration out of vgmanager and into an own
lvmd
package. Also adds Type aliases for topolvm lvmd configuration that is used so we never use topolvm lvmd packages directly outside of our own lvmd package.To make type aliasing work I also had to bump the controller-gen tool to latest, since in controller-gen <0.8.0 there is a type aliasing bug that prevents us from doing type aliasing.