Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-677: chore: separate lvmd package from vgmanager #411

Conversation

jakobmoellerdev
Copy link
Contributor

Part of vgmanager refactoring. This refactors the lvmd configuration out of vgmanager and into an own lvmd package. Also adds Type aliases for topolvm lvmd configuration that is used so we never use topolvm lvmd packages directly outside of our own lvmd package.
To make type aliasing work I also had to bump the controller-gen tool to latest, since in controller-gen <0.8.0 there is a type aliasing bug that prevents us from doing type aliasing.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2023

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of vgmanager refactoring. This refactors the lvmd configuration out of vgmanager and into an own lvmd package. Also adds Type aliases for topolvm lvmd configuration that is used so we never use topolvm lvmd packages directly outside of our own lvmd package.
To make type aliasing work I also had to bump the controller-gen tool to latest, since in controller-gen <0.8.0 there is a type aliasing bug that prevents us from doing type aliasing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #411 (30d78ab) into main (8208b3a) will decrease coverage by 1.29%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   53.95%   52.67%   -1.29%     
==========================================
  Files          27       27              
  Lines        2376     2561     +185     
==========================================
+ Hits         1282     1349      +67     
- Misses       1007     1127     +120     
+ Partials       87       85       -2     
Files Changed Coverage Δ
pkg/vgmanager/vgmanager_controller.go 11.20% <0.00%> (+1.62%) ⬆️

... and 4 files with indirect coverage changes

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-677-lvmd-separation branch 2 times, most recently from 47eb80c to d5ecced Compare September 8, 2023 18:21
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-677-lvmd-separation branch from d5ecced to 30d78ab Compare September 8, 2023 20:18
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8a0a648 into openshift:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants