OCPVE-670: fix ownerref alignment and deletion logic on removal

[jakobmoellerdev]

Deletion Logic was revamped for all the resourceManagers. also fixes up various log messages to have a consistent form during deletion.
Also adjusts the unit tests to correctly work with ownerref removal. Also makes sure that the Owner references are always set in the create or update logic since otherwise they would not be updated.

Removes ensureDeleted for controllers/topolvm_node.go as well as controllers/topolvm_controller.go

Also kills multierror and its only call in favor or errors.Join

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-670 which is a valid jira issue.

In response to this:

Deletion Logic was revamped for all the resourceManagers. also fixes up various log messages to have a consistent form during deletion.
Also adjusts the unit tests to correctly work with ownerref removal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-670 which is a valid jira issue.

In response to this:

Deletion Logic was revamped for all the resourceManagers. also fixes up various log messages to have a consistent form during deletion.
Also adjusts the unit tests to correctly work with ownerref removal. Also makes sure that the Owner references are always set in the create or update logic since otherwise they would not be updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test all

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-670 which is a valid jira issue.

In response to this:

Deletion Logic was revamped for all the resourceManagers. also fixes up various log messages to have a consistent form during deletion.
Also adjusts the unit tests to correctly work with ownerref removal. Also makes sure that the Owner references are always set in the create or update logic since otherwise they would not be updated.

Removes ensureDeleted for controllers/topolvm_node.go as well as controllers/topolvm_controller.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-670 which is a valid jira issue.

In response to this:

Deletion Logic was revamped for all the resourceManagers. also fixes up various log messages to have a consistent form during deletion.
Also adjusts the unit tests to correctly work with ownerref removal. Also makes sure that the Owner references are always set in the create or update logic since otherwise they would not be updated.

Removes ensureDeleted for controllers/topolvm_node.go as well as controllers/topolvm_controller.go

Also kills multierror and its only call in favor or errors.Join

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[suleymanakbas91]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.