Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default socket paths from topolvm project #39

Merged
merged 2 commits into from
Dec 22, 2021
Merged

fix: use default socket paths from topolvm project #39

merged 2 commits into from
Dec 22, 2021

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 22, 2021

  • Make use of default path mentioned in topolvm project for CSI Socket
    and LVMd Socket files

Signed-off-by: Leela Venkaiah G [email protected]

@leelavg leelavg requested review from nbalacha and sp98 December 22, 2021 08:09
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
@leelavg leelavg marked this pull request as draft December 22, 2021 09:17
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2021
- Make use of default path mentioned in topolvm project for CSI Socket
  and LVMd Socket files

Signed-off-by: Leela Venkaiah G <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
@leelavg leelavg marked this pull request as ready for review December 22, 2021 09:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmolmo, leelavg, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit f7794c3 into openshift:main Dec 22, 2021
@leelavg leelavg deleted the default-names branch December 29, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants