Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-620: docs: add guidance on Multi-Node Topology Snapshotting #384

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Creates a guidance documentation on Snapshotting and Cloning in Multi-Node Topologies. It specifically recommends to use Stateful Sets alongside preprovisioned and bound source PVCs to avoid running into scheduler limitations that may (or may not) occur in TopoLVM CSI scheduling (I opened a discussion in topolvm/topolvm#737 to clarify the exact conditions, also I am trying to independently verify this issue).

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-620-Snapshot-Docs branch from 93227a6 to aebbbee Compare August 16, 2023 15:04
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-620-Snapshot-Docs branch from aebbbee to 9d870f7 Compare August 16, 2023 15:06
@jakobmoellerdev jakobmoellerdev changed the title docs: add guidance on Multi-Node Topology Snapshotting OCPVE-620: docs: add guidance on Multi-Node Topology Snapshotting Aug 16, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@jakobmoellerdev: This pull request references OCPVE-620 which is a valid jira issue.

In response to this:

Creates a guidance documentation on Snapshotting and Cloning in Multi-Node Topologies. It specifically recommends to use Stateful Sets alongside preprovisioned and bound source PVCs to avoid running into scheduler limitations that may (or may not) occur in TopoLVM CSI scheduling (I opened a discussion in topolvm/topolvm#737 to clarify the exact conditions, also I am trying to independently verify this issue).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 16, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-620-Snapshot-Docs branch from 9d870f7 to 1812657 Compare August 21, 2023 10:15
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review August 21, 2023 10:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@openshift-ci openshift-ci bot requested review from jeff-roche and qJkee August 21, 2023 10:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #384 (1812657) into main (a962b90) will increase coverage by 43.34%.
Report is 37 commits behind head on main.
The diff coverage is 73.39%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #384       +/-   ##
===========================================
+ Coverage   16.59%   59.93%   +43.34%     
===========================================
  Files          24       26        +2     
  Lines        2061     2631      +570     
===========================================
+ Hits          342     1577     +1235     
+ Misses       1693      950      -743     
- Partials       26      104       +78     
Files Changed Coverage Δ
controllers/lvmcluster_controller_watches.go 90.32% <ø> (+90.32%) ⬆️
pkg/vgmanager/vgmanager_controller.go 11.57% <0.00%> (+11.57%) ⬆️
controllers/topolvm_snapshotclass.go 68.65% <10.00%> (+68.65%) ⬆️
controllers/lvmcluster_controller.go 65.41% <66.66%> (+65.41%) ⬆️
pkg/cluster/leaderelection.go 66.66% <66.66%> (ø)
pkg/cluster/sno.go 72.72% <72.72%> (ø)
controllers/topolvm_controller.go 95.74% <100.00%> (+95.74%) ⬆️
pkg/vgmanager/devices.go 76.80% <100.00%> (+2.60%) ⬆️

... and 10 files with indirect coverage changes

@suleymanakbas91
Copy link
Contributor

Great explanation!
/lgtm
/approve
/hold
for docs team to review.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@jakobmoellerdev
Copy link
Contributor Author

/unhold @johnwilkins made a pass over this

@jakobmoellerdev
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit df026f6 into openshift:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants