OCPVE-616: fix: add check of correct lv state of thin-pool when vg is already created

[jakobmoellerdev]

This introduces new checks when the LV was already created as a thin pool to ensure correct status updates even after the VG was setup initially.

Checks include:

• LV is present
• LV is of type Thin-Pool and was not wrongly converted
• lv is active
• has <95% metadata usage (as LVM will crash on most I/O if on entire thin-pool if there is a metadata volume overflow, as by consulting the man-page of lvm: Metadata space exhaustion can lead to inconsistent thin pool metadata and inconsistent file systems, so the response requires offline checking and repair.), allowing users to still circumvent with lvextend --poolmetadatasize in case of overprovisioning. This allow users to avoid having to reboot the node and repair the deactivated LV

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-616 which is a valid jira issue.

In response to this:

This introduces new checks when the LV was already created as a thin pool to ensure correct status updates even after the VG was setup initially.

Checks include:

• LV is present
• LV is of type Thin-Pool and was not wrongly converted
• lv is active
• has <95% metadata usage (as LVM will crash on most I/O if on entire thin-pool if there is a metadata volume overflow, as by consulting the man-page of lvm: Metadata space exhaustion can lead to inconsistent thin pool metadata and inconsistent file systems, so the response requires offline checking and repair.), allowing users to still circumvent with lvextend --poolmetadatasize in case of overprovisioning. This allow users to avoid having to reboot the node and repair the deactivated LV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #381 (d270241) into main (a962b90) will increase coverage by 39.09%.
Report is 18 commits behind head on main.
The diff coverage is 67.56%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #381       +/-   ##
===========================================
+ Coverage   16.59%   55.69%   +39.09%     
===========================================
  Files          24       26        +2     
  Lines        2061     2223      +162     
===========================================
+ Hits          342     1238      +896     
+ Misses       1693      896      -797     
- Partials       26       89       +63     

Files Changed	Coverage Δ
pkg/vgmanager/lvm.go	52.03% <ø> (+4.06%)	⬆️
pkg/vgmanager/vgmanager_controller.go	6.59% <35.18%> (+6.59%)	⬆️
pkg/cluster/leaderelection.go	66.66% <66.66%> (ø)
pkg/vgmanager/devices.go	73.77% <81.25%> (-0.43%)	⬇️
pkg/vgmanager/lv_attr.go	92.59% <92.59%> (ø)
controllers/lvmcluster_controller.go	60.00% <100.00%> (+60.00%)	⬆️
controllers/topolvm_controller.go	94.14% <100.00%> (+94.14%)	⬆️

... and 10 files with indirect coverage changes

[suleymanakbas91]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD edc65d7 and 2 for PR HEAD aeb67cc in total

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.