Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: operator now watches own namespace #28

Merged
merged 1 commit into from
Dec 20, 2021
Merged

controller: operator now watches own namespace #28

merged 1 commit into from
Dec 20, 2021

Conversation

nbalacha
Copy link
Contributor

This introduces the WATCH_NAMESPACE env which is set the the operator's
own namespace. This allows the operator to be configured to watch only its
own namespace.

Signed-off-by: N Balachandran [email protected]

This introduces the WATCH_NAMESPACE env which is set the the operator's
own namespace. This allows the operator to be configured to watch only its
own namespace.

Signed-off-by: N Balachandran <[email protected]>
@@ -52,5 +52,10 @@ spec:
requests:
cpu: 100m
memory: 20Mi
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • when installing via bundle we'll specify the namespace in which this operator should be installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2021

@leelavg: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit d91f7db into openshift:main Dec 20, 2021
@nbalacha nbalacha deleted the watch branch December 20, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants