Design doc #2
Merged
Design doc #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan CJ <[email protected]>
Signed-off-by: Rohan CJ <[email protected]>
Signed-off-by: Rohan CJ <[email protected]>
nbalacha
reviewed
Dec 3, 2021
| # Controllers and their managed resources | ||
|
|
||
|
|
||
| - **lvmcluster-controller:** Running in the operator deployment, it will create all resources that are don't require information from the node. When applicable, the health of the underlying resource is updated in the LVMCluster status and errors are also exposed as events. Overall success also passed on as an event.: |
There was a problem hiding this comment.
This will be a separate pod, not part of the operator deployment.
There was a problem hiding this comment.
This is referring to the mian reconcile loop in the operator deployment. This is not referring to the CSI driver component topolvmcluster-controller.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See preview