Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementation of csidriver resource unit #18

Merged
merged 3 commits into from
Dec 15, 2021
Merged

feat: implementation of csidriver resource unit #18

merged 3 commits into from
Dec 15, 2021

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 13, 2021

  • implemented create and delete reconcile actions on CSIDriver resource
  • added rbac roles to manager to manager csidriver resource

Signed-off-by: Leela Venkaiah G [email protected]

@leelavg
Copy link
Contributor Author

leelavg commented Dec 13, 2021

nbalacha
nbalacha suggested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Also, please split this into 2 commits - 1 for the code changes and 1 for the manifest changes after regenerating them.

controllers/topolvm_csi_driver.go Outdated Show resolved Hide resolved
controllers/topolvm_csi_driver.go Outdated Show resolved Hide resolved
controllers/topolvm_csi_driver.go Outdated Show resolved Hide resolved
@leelavg
Copy link
Contributor Author

leelavg commented Dec 14, 2021

  • tested against a live cluster by deploying, updating and deleting lvmcluster CR and observing reconciliation of csidriver resource unit
  • reg addition of list & watch verbs, operator-sdk seems to be building up sharedinformercache using client-go's watch&list functions and so added those verbs as well

@leelavg leelavg requested a review from nbalacha December 14, 2021 03:11
@leelavg leelavg mentioned this pull request Dec 14, 2021
Closed
@nbalacha
Copy link
Contributor

/lgtm

nbalacha
nbalacha suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the delete test

@leelavg
feat: implementation of csidriver resource unit
372623a 
- implemented resourceManager interface of reconciler for csidriver resource unit

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg
feat: added rbac for csidriver resource unit
4f8b5f5 
- added operator rbac to deploy topolvm csi driver resource

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg
test: unit test for CSIDriver resource deployment
e1b7119 
Signed-off-by: Leela Venkaiah G <[email protected]>
nbalacha
nbalacha approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nbalacha nbalacha merged commit 3de5275 into openshift:main Dec 15, 2021
@leelavg leelavg deleted the csidriver branch December 21, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbalacha nbalacha nbalacha approved these changes

@sp98 sp98 sp98 approved these changes

@jmolmo jmolmo jmolmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leelavg @nbalacha @jmolmo @sp98