Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add nameprefix to the controller manager #128

Merged
merged 1 commit into from
Mar 11, 2022
Merged

build: add nameprefix to the controller manager #128

merged 1 commit into from
Mar 11, 2022

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Mar 9, 2022 •
edited
Loading

@iamniting iamniting requested review from nbalacha and leelavg March 9, 2022 10:06
leelavg
leelavg approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
nbalacha
nbalacha reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@nbalacha nbalacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for the controller-manager deployment and pod. Is there any way to do this for the serviceaccount as well?

@leelavg
Copy link
Contributor

leelavg commented Mar 10, 2022

  • I suppose you mean the controller-manager service account
  • If that's the case we may need to write a patch file targeting only this serviceAccount and corresponding roles/roleBindings/deployment as I believe we can't set this via kustomize cli
  • Needs to be investigated further

@iamniting
Copy link
Member Author

This works for the controller-manager deployment and pod. Is there any way to do this for the serviceaccount as well?

We could do that, But eventually, it will bring much more complexity in the kustomize and makefile because of rbacs and all, I would suggest that we just change the name of the service account to something appropriate so that it won't conflict with something else.

@iamniting iamniting requested a review from nbalacha March 11, 2022 10:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@nbalacha
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 554b2ef into openshift:main Mar 11, 2022
@iamniting iamniting deleted the name branch April 13, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg approved these changes

@nbalacha nbalacha nbalacha approved these changes

Assignees

@nbalacha nbalacha

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iamniting @leelavg @nbalacha @openshift-merge-robot