Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CentOS Stream 8 for images #107

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

javierpena
Copy link
Contributor

CentOS Linux 8 repositories were removed from the mirror network on
January 31 [1]. That breaks the combined and vgmanager images, which
should switch to CentOS Stream 8.

[1] - https://lists.centos.org/pipermail/centos-devel/2021-December/098779.html

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2022
@nbalacha
Copy link
Contributor

The changes are fine. Please update the commit msg with the following changes

  1. Include Signed-off-by:
    Signed-off-by: Author Name [email protected]

  2. Commit msg subject line :
    fix: use CentOS Stream 8 for images

Thank you.

CentOS Linux 8 repositories were removed from the mirror network on
January 31 [1]. That breaks the combined and vgmanager images, which
should switch to CentOS Stream 8.

[1] - https://lists.centos.org/pipermail/centos-devel/2021-December/098779.html

Signed-off-by: Javier Pena <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@javierpena
Copy link
Contributor Author

I've added the required fixes to the commit msg. Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@nbalacha
Copy link
Contributor

/lgtm /approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javierpena, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit f7b7b1b into openshift:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants