Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1835: Add an openshift-tests-extension compatible test binary #2105

Merged
merged 2 commits into from
Nov 11, 2024
Merged

TRT-1835: Add an openshift-tests-extension compatible test binary #2105

merged 2 commits into from
Nov 11, 2024

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Oct 7, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR creates a binary compatible with openshift-tests-extension, as per the enhancement detailed at openshift/enhancements#1676.

Which issue(s) this PR fixes:

TRT-1835

Special notes for your reviewer:

Creates a separate binary "k8s-test-ext" while we validate it works, link up the origin parts, etc. It'll replace k8s-tests eventually.

Does this PR introduce a user-facing change?

NO

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Build it:

$ make WHAT="openshift-hack/cmd/k8s-tests-ext" KUBE_VERBOSE=3

Some things to try:

$ ./_output/bin/k8s-tests-ext info

$ ./_output/bin/k8s-tests-ext list

$ export TEST_PROVIDER='{"type":"aws"}'
$ export KUBECONFIG=/tmp/kubeconfig
$ ./_output/bin/k8s-tests-ext run-test "[sig-storage] ConfigMap should be immutable if \`immutable\` field is set [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]"

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 7, 2024
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 7, 2024
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 October 7, 2024 14:40
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 7, 2024
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam stbenjam marked this pull request as draft October 7, 2024 14:42
@stbenjam
Copy link
Member Author

stbenjam commented Oct 7, 2024

/test verify
/test images

@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 7, 2024

/test images

@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam stbenjam marked this pull request as ready for review October 7, 2024 16:13
@openshift-ci openshift-ci bot requested review from bertinatto and tkashem October 7, 2024 16:15
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam
Copy link
Member Author

stbenjam commented Oct 7, 2024

/test verify

1 similar comment
@stbenjam
Copy link
Member Author

stbenjam commented Oct 7, 2024

/test verify

@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam stbenjam changed the title [WIP] Migrate k8s-tests to openshift-tests-extension [WIP] Add an openshift-tests-extension compatible test binary Oct 8, 2024
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 960cb69 and 2 for PR HEAD 64905e0 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 960cb69 and 2 for PR HEAD 64905e0 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d831e17 and 1 for PR HEAD 64905e0 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7a7a8d and 0 for PR HEAD 64905e0 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Nov 8, 2024
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@stbenjam
UPSTREAM: <carry>: add openshift-tests-extension compatible binary
da405c0
@stbenjam
UPSTREAM: <drop>: ./hack/update-vendor.sh
0669dae 
Ran:

./hack/pin-dependency.sh github.com/onsi/ginkgo/v2=github.com/openshift/onsi-ginkgo/v2 v2.19-openshift-4.18
./hack/pin-dependency.sh github.com/openshift-eng/openshift-tests-extension main
./hack/update-vendor.sh
./hack/update-go-workspace.sh
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@openshift-ci-robot
Copy link

@stbenjam: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 8, 2024

/test integration

@bertinatto
Copy link
Member

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Nov 8, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7a7a8d and 2 for PR HEAD 0669dae in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2024 •
edited
Loading

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 0669dae link false /test e2e-agnostic-ovn-cmd
ci/prow/k8s-e2e-aws-ovn-serial 0669dae link false /test k8s-e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7a7a8d and 2 for PR HEAD 0669dae in total

@openshift-merge-bot openshift-merge-bot bot merged commit a3f31a4 into openshift:master Nov 11, 2024
22 of 24 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202411111538.p0.ga3f31a4.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202411111538.p0.ga3f31a4.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202411111538.p0.ga3f31a4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stbenjam @openshift-ci-robot @bertinatto @openshift-bot @openshift-merge-robot