NOJIRA: fix: updating the makefile go install command for ci, making tests ve… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbose, and adding the codecov script for ci
jeff-roche
commented
Dec 11, 2024
There was a problem hiding this comment.
This is just a copy/pasta from lvm-operator
jeff-roche
commented
Dec 11, 2024
| @@ -244,7 +247,7 @@ set -e; \ | |||
| package=$(2)@$(3) ;\ | |||
| echo "Downloading $${package}" ;\ | |||
| rm -f $(1) || true ;\ | |||
| GOBIN=$(LOCALBIN) go install $${package} ;\ | |||
| GOBIN=$(LOCALBIN) go install -mod=readonly $${package} ;\ | |||
There was a problem hiding this comment.
Without -mod=readonly, go install fails in CI because of vendoring. This makes install ignore vendoring and install the dependency requested
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
go testin the makefilemake testgo-install-tooldirective in the makefile to respect vendoring (breaks dependency bin installs in CI)