Init #1
Closed
Init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mod
Outdated
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| k8s.io/api v0.30.1 // indirect | ||
| k8s.io/apiextensions-apiserver v0.30.1 // indirect | ||
| k8s.io/apiserver v0.30.1 // indirect |
There was a problem hiding this comment.
Can we already bump k8s to 1.31 so that we won't need to upgrade it later on?
There was a problem hiding this comment.
AFAICT the latest operator-sdk is still on k8s 1.30 :/
There was a problem hiding this comment.
But we still can bump it manually
jeff-roche
approved these changes
Dec 5, 2024
qJkee
reviewed
Dec 5, 2024
.golangci.yml
Outdated
| @@ -0,0 +1,47 @@ | |||
| run: | |||
LICENSE
Outdated
| @@ -1,201 +0,0 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Why did you delete this? We need to have License file in repo
There was a problem hiding this comment.
Ah, result of not rebasing. Will fix
PROJECT
Outdated
| manifests.sdk.operatorframework.io/v2: {} | ||
| scorecard.sdk.operatorframework.io/v2: {} | ||
| projectName: ksan-operator | ||
| repo: github.com/copejon/ksan-operator |
PROJECT
Outdated
| crdVersion: v1 | ||
| namespaced: true | ||
| controller: true | ||
| domain: ksan-operator.storage.openshift.io |
| controller-gen.kubebuilder.io/version: v0.15.0 | ||
| name: ksanclusters.ksan.ksan-operator.storage.openshift.io | ||
| spec: | ||
| group: ksan.ksan-operator.storage.openshift.io |
There was a problem hiding this comment.
in doc we have ksan.openshift.io
qJkee
suggested changes
Dec 5, 2024
OWNERS
Outdated
| - jeff-roche | ||
| - jerpeter1 | ||
| - pacevedom | ||
| - pmtk |
There was a problem hiding this comment.
i don't think that we need that much people, especially for approvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the operator framework and a primitive api