Add support for cpumanager LLC alignment option #1724
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ffromani
force-pushed
the
cpumanager-alpha-options-llc
branch
2 times, most recently
from
8403b26 to
b7448a1
Compare
add feature gate to enable selected users to consume cpumanager policy options of alfpha maturtiy. Needs to be merged alongside openshift/kubernetes#2136 which enables per-option granularity for more details: openshift/enhancements#1724 Signed-off-by: Francesco Romani <[email protected]>
|
xref: openshift/api#2115 |
|
it's not clear to me which option you prefer / is the current recommendation. I would recommend choosing one and then leaving the others as alternatives. Personally, I think going strict enablement file route may be cleanest because then user doesn't need to attempt to enable an alpha feature gate, plus they don't get the full bundle of alpha features but just the one we're specifically allowing. Alternatively, we could introduce an openshift specific feature gate that enables which then would have both API visibility but a smaller surface of code changes. |
| The risks are thus minimized; users may forget to set the enablement file. | ||
| The mitigation is to have clear documentation about the requisite to set the feature to on | ||
|
|
||
| #### 3: Just the per-option extra enablement file |
In this enhancement we focus on how to unpack cpumanager policy option, as the rest of the process seems straightforward. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
cpumanager-alpha-options-llc
branch
from
b7448a1 to
47e21fc
Compare
|
updated to address all comments, so we now have a track record |
|
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Enhancement to support the cpu LLC alignment feature introduced as alpha in kubernetes 1.32.
In this enhancement we focus on how to unpack cpumanager policy option, as the rest of the process seems straightforward.