Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1825: describe multi-operator-manager #1721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 26, 2024

Describe the MOM basics. Probably need a section with a link to a clean example (or blog post style format?) of how to write a test.

/assign @p0lyn0mial @bertinatto

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@deads2k: This pull request references API-1825 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Describe the MOM basics. Probably need a section with a link to a clean example (or blog post style format?) of how to write a test.

/assign @p0lyn0mial @bertinatto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from deads2k. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@p0lyn0mial p0lyn0mial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


HCP and standalone topologies face a problem of inconsistency and duplicate effort to introduce features
because they are two entirely distinct mechanisms for managing the same operands.
While some differences are absolutely required (deployments vs static pods), many are simply capricous.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: capricious

dev-guide/multi-operator-manager.md Show resolved Hide resolved

### Goals

* Keep teams aligned to units of function across all form-factors (desired by everyone I think)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this sentence, wdym?

### Goals

* Keep teams aligned to units of function across all form-factors (desired by everyone I think)
* Dramatically reduce overhead of running operators (single-node and HCP constraints)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more specific about what overheads we have and the listed platforms?

Before we get into the changes, we need to define some terms.

1. configuration cluster - this is a theoretical (doesn't really exist) kuberentes cluster that contains
the configuration that the user provides and the operators interact with.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we disambiguate "the user" by using specific Personas? e.g. is this is user a cluster admin, a service consumer, service provider, a developer, ...?

We will refactor existing operators to continue running as they do today and also fulfill the
contract of these new commands.

1. `operator input-resources` - outputs a list of kube API input resources that this operator needs
Copy link
Member

@enxebre enxebre Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to pick a concrete use case for a concrete operator and flesh out the e2e journey for the new contract for both scenarios standalone and hypershift

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/cluster-authentication-operator now has input-resources, output-resources, and apply-configuration commands that function (not yet guaranteed compatible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants