Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-4538: MicroShift Gateway api support #1699

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

pacevedom
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2024

@pacevedom: This pull request references USHIFT-4538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2024
@pacevedom
Copy link
Contributor Author

/cc @pmtk
/cc @jerpeter1
/cc @eslutsky
/cc @copejon
/cc @dgn
/cc @shaneutt
/cc @ggiguash

enhancements/microshift/gateway-api-support.md Outdated Show resolved Hide resolved
enhancements/microshift/gateway-api-support.md Outdated Show resolved Hide resolved
enhancements/microshift/gateway-api-support.md Outdated Show resolved Hide resolved
enhancements/microshift/gateway-api-support.md Outdated Show resolved Hide resolved
@pmtk
Copy link
Member

pmtk commented Oct 21, 2024

just one minor question, otherwise looks good to me

@candita
Copy link
Contributor

candita commented Oct 21, 2024

Overall, I think you need to make sure your research is conducted on MicroShift without a Cluster Ingress running, and that you are really using the Istio gateway controller name and not the Cluster Ingress gateway controller name.

Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jerpeter1 jerpeter1 self-assigned this Oct 30, 2024
@jerpeter1
Copy link
Member

@candita, @shaneutt - do you have any more feedback?

@shaneutt
Copy link
Member

I am all set, thank you!

@candita
Copy link
Contributor

candita commented Oct 30, 2024

@candita - do you have any more feedback?

I don't see any major problems except use of the phrase "support" and especially "full support". But there were a bunch of resolved comments that didn't seem to be followed with any changes. No worries, as long as you know that some of these things may occur, I suppose you don't have to address everything in the enhancement proposal.

@pacevedom
Copy link
Contributor Author

I don't see any major problems except use of the phrase "support" and especially "full support". But there were a bunch of resolved comments that didn't seem to be followed with any changes. No worries, as long as you know that some of these things may occur, I suppose you don't have to address everything in the enhancement proposal.

We should not have any more "full support" claims, and those that refer to "support" should have been updated to state that we do not offer anything that is past OSSM3 capabilities.
As for the resolved comments I left a note in two of them. Thanks!

@jerpeter1
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d017033 into openshift:master Oct 31, 2024
2 checks passed
@pacevedom pacevedom deleted the USHIFT-4538 branch October 31, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants