-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-4538: MicroShift Gateway api support #1699
Conversation
@pacevedom: This pull request references USHIFT-4538 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c8001ae
to
20436c2
Compare
just one minor question, otherwise looks good to me |
Overall, I think you need to make sure your research is conducted on MicroShift without a Cluster Ingress running, and that you are really using the Istio gateway controller name and not the Cluster Ingress gateway controller name. |
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I am all set, thank you! |
I don't see any major problems except use of the phrase "support" and especially "full support". But there were a bunch of resolved comments that didn't seem to be followed with any changes. No worries, as long as you know that some of these things may occur, I suppose you don't have to address everything in the enhancement proposal. |
We should not have any more "full support" claims, and those that refer to "support" should have been updated to state that we do not offer anything that is past OSSM3 capabilities. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerpeter1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.