Provide Labels and/or Units for Ordinates?

[martin-aders]

On the Grafana dashboards in OpenShift, I wonder why the ordinates are not labeled. Example: "API Request Duration by Verb - 99th Percentile" metric had a peak of "4" on a cluster. Now I'm used to read response times in milliseconds. Only when opening the details via "Inspect" in a separate tab I see that the metric rather uses seconds instead of milliseconds. "4ms" is less worrying than "4s" for a response time. Is there a specific reason that axes are never labeled? Either axis labels or unit names would help to read the charts more quickly without zooming into each metric separately.

cluster-kube-apiserver-operator/manifests/0000_90_kube-apiserver-operator_05_api_performance_dashboard.yaml

Line 139 in 37df1b1

"align": false,

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[martin-aders]

/remove-lifecycle stale

Confirming that the y-axis still lacks units ("ms" in this case) as of OCP 4.17.5 and on the main branch. I compared the source with the etcd-dashboard which does use units on the y axis. The main difference I could find was the usage of "short" format (no unit displayed) vs the "s" format (for use with metrics in seconds). For milliseconds "ms" seems to be used but the metrics are all in seconds for the whole dashboard.

Here's the diff between the mentioned apiserver metric and the etcd dashboard "Disk Sync Duration":

Suggestion: Use the unit "s" instead of "short" for all 7 dashboards which have "duration" in the title to display the time unit second on the y axis:

• "API Request Duration by Verb - 99th Percentile" -> apiserver_request_duration_seconds_bucket
• "etcd Request Duration - 99th Percentile" -> etcd_request_duration_seconds_bucket
• "Request Duration by Resource and Verb - 99th Percentile" -> apiserver_request_duration_seconds_bucket
• "Request Duration by Read vs Write - 99th Percentile" -> apiserver_request_duration_seconds_bucket
• "Priority & Fairness: Request Wait Duration - 99th Percentile" -> apiserver_flowcontrol_request_wait_duration_seconds_bucket
• "Priority & Fairness: Request Execution Duration - 99th Percentile" -> apiserver_flowcontrol_request_execution_seconds_bucket
• "Server Filter Duration - 99th Percentile" -> apiserver_request_filter_duration_seconds_bucket

Hope that makes the issue more specific and the solution clearer (replace 7x the term "short" by "s"). Would that be acceptable to change or is there anything I don't know that could block this change?