Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1822: Make registry available from squid proxy as well #1702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Sep 17, 2024

openshift-tests now runs some tests by extracting additional binaries from the payload, but on disconnected installs we need to be able to reach the mirror from the build cluster.

Once we know the provisioning network's IP for the local registry, this modifies any running squid container to include this in /etc/hosts so it's reachable.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@openshift-ci openshift-ci bot requested review from bfournie and sadasu September 17, 2024 12:51
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

Not sure if this works from dev-scripts:

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

@stbenjam stbenjam force-pushed the registry branch 2 times, most recently from 8cfd0fc to 451d83f Compare September 17, 2024 15:16
@stbenjam stbenjam changed the title [wip] Make registry available from squid proxy as well TRT-1822: Make registry available from squid proxy as well Sep 17, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@stbenjam
Copy link
Member Author

/hold

It's still not working :(

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@stbenjam
Copy link
Member Author

/test ci/prow/e2e-metal-ipi-bm

Copy link

openshift-ci bot commented Sep 18, 2024

@stbenjam: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test e2e-metal-ipi-bm
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial-ipv4
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test e2e-metal-ipi-bm-bond
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-v6
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-upgrade-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-ha-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-agent-sno-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-bm
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-bm-bond
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-metal3-dev-scripts-master-images

In response to this:

/test ci/prow/e2e-metal-ipi-bm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member Author

/test e2e-metal-ipi-bm

Copy link

openshift-ci bot commented Sep 18, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 77fedd8 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm 77fedd8 link true /test e2e-metal-ipi-bm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant