Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yq command to be compatible with yq v4 #1621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix yq command to be compatible with yq v4 #1621

wants to merge 1 commit into from

Conversation

mnietoji
Copy link

Option -y is not available in yq version 4 that
is the one being installed
#1620

@mnietoji
Fix yq command to be compatible with yq v4
4154f48 
Option -y is not available in yq version 4 that
is the one being installed
openshift-metal3#1620
@openshift-ci openshift-ci bot requested review from elfosardo and sadasu December 19, 2023 09:28
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cybertron for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 19, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

Hi @mnietoji. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Dec 22, 2023
@mnietoji
hybrid_deployment tigon28
1fa9c99 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Jan 8, 2024
@mnietoji
hybrid_deployment tigon28
6791260 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Jan 9, 2024
@mnietoji
hybrid_deployment tigon28
74584a7 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Jan 15, 2024
@mnietoji
hybrid_deployment tigon28
0cb84e5 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Jan 23, 2024
@mnietoji
hybrid_deployment tigon28
5e0380e 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Jan 26, 2024
@mnietoji
hybrid_deployment tigon28
f593daa 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
@eshulman2
Copy link

Hi @elfosardo @sadasu can you please review/comment on this patch.

mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 1, 2024
@mnietoji
hybrid_deployment panther05
5631f62 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 2, 2024
@mnietoji
hybrid_deployment tigon28
327a894 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

/retest

mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 5, 2024
@mnietoji
hybrid_deployment panther05
70d30be 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 5, 2024
@mnietoji
hybrid_deployment tigon28
4fd0c84 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
@sadasu
Copy link
Contributor

sadasu commented Feb 5, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2024
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 6, 2024
@mnietoji
hybrid_deployment tigon28
1b8fe4f 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 9, 2024
@mnietoji
hybrid_deployment panther05
e5625d1 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 9, 2024
@mnietoji
hybrid_deployment tigon28
d51c021 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
mnietoji added a commit to mnietoji/ci-framework that referenced this pull request Feb 13, 2024
@mnietoji
hybrid_deployment panther05
99b8c4f 
fix issue in dev_scripts
openshift-metal3/dev-scripts#1621
@sadasu
Copy link
Contributor

sadasu commented Feb 13, 2024

/retest-required

1 similar comment
@eshulman2
Copy link

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 6, 2024

@mnietoji: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 4154f48 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack 4154f48 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-agent-ha-dualstack 4154f48 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-sno-ipv6 4154f48 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-virtualmedia 4154f48 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 4154f48 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ipv4 4154f48 link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi-bm 4154f48 link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-ovn-ipv6 4154f48 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4 4154f48 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Member

I beleive the latest available version in pypi is still 3.x
I'd rather pin yq version installed so when the new version comes out we don't break dev-scripts

@elfosardo
Copy link
Member

/hold
this can be closed, yq version has been pinned

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

@sadasu sadasu Awaiting requested review from sadasu

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnietoji @eshulman2 @sadasu @elfosardo