Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.0 for future release #95

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

harshavamsi
Copy link
Contributor

Signed-off-by: Harsha Vamsi Kalluri [email protected]

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi requested review from a team and Yury-Fridlyand as code owners September 7, 2022 23:01
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshavamsi.
May be we could start automating the bumps. We do this across the project[1]
I can open up issue. https://github.com/opensearch-project/opensearch-net/issues/96

[1] https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/version.yml

MaxKsyunz
MaxKsyunz previously approved these changes Sep 8, 2022
VachaShah
VachaShah previously approved these changes Sep 8, 2022
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi changed the title Bump version to 1.1.1 for future release Bump version to 1.2.0 for future release Sep 8, 2022
@harshavamsi
Copy link
Contributor Author

@VachaShah @MaxKsyunz @Yury-Fridlyand bumped version to 1.2.0 because we'd like to stay on a minor version instead of a patch for future releases.

@dblock
Copy link
Member

dblock commented Sep 19, 2022

We should be following semver, not OpenSearch. Are there new features added already? If it’s only fixed then bump patch.

@Yury-Fridlyand
Copy link
Collaborator

#66 was added recently.

@harshavamsi
Copy link
Contributor Author

@dblock this is essential for Sigv4. We've already merged #66.

@dblock dblock merged commit d5acb7c into opensearch-project:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants