[Backport 1.x] Add support for component template APIs (#411) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate `cluster.put_component_template` Signed-off-by: Thomas Farr <[email protected]> * Implement high-level DeleteComponentTemplate Signed-off-by: Thomas Farr <[email protected]> * Implement high-level ComponentTemplateExists Signed-off-by: Thomas Farr <[email protected]> * Fix license Signed-off-by: Thomas Farr <[email protected]> * Remove old put_component_template Signed-off-by: Thomas Farr <[email protected]> * Implement high-level GetComponentTemplate Signed-off-by: Thomas Farr <[email protected]> * Add tests for ComponentTemplateExists Signed-off-by: Thomas Farr <[email protected]> * Add tests for DeleteComponentTemplate Signed-off-by: Thomas Farr <[email protected]> * Add tests for GetComponentTemplate Signed-off-by: Thomas Farr <[email protected]> * Implement high-level PutComponentTemplate Signed-off-by: Thomas Farr <[email protected]> * Add component template CRUD tests Signed-off-by: Thomas Farr <[email protected]> * Add naming convention exception for ComponentTemplateExists Signed-off-by: Thomas Farr <[email protected]> * Update guide Signed-off-by: Thomas Farr <[email protected]> * Formatting Signed-off-by: Thomas Farr <[email protected]> * Add changelog entry Signed-off-by: Thomas Farr <[email protected]> * Fix license header Signed-off-by: Thomas Farr <[email protected]> * Fix namespaces Signed-off-by: Thomas Farr <[email protected]> * Fix license header Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 7eedc00)
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
|
@dblock When you have time could you review this please? |
dblock
approved these changes
Nov 21, 2023
|
Tests are failing for good reason it may seem? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport 7eedc00 from #411
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.