Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Provide a way to make .Strict(true) be the default behavior for all queries #375

Open
DumboJet opened this issue Sep 25, 2023 · 0 comments
Open

[FEATURE] Provide a way to make .Strict(true) be the default behavior for all queries #375

DumboJet opened this issue Sep 25, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DumboJet
Copy link

Is your feature request related to a problem?

Applying the .Strict(true) to each sub-query is a lot of work and you can always miss something.

What solution would you like?

Having a way to make .Strict(true) be the default behavior (perhaps for a QueryContainer and all its children?) would probably be a nice feature. It would save people from a lot of silent bugs, where queries become conditionless and are not serialized.
@DumboJet DumboJet added enhancement New feature or request untriaged labels Sep 25, 2023
@DumboJet DumboJet mentioned this issue Sep 25, 2023
Closed
@Xtansia Xtansia added good first issue Good for newcomers and removed untriaged labels Sep 26, 2023
@DumboJetEngine DumboJetEngine mentioned this issue Jan 4, 2024
Open
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 8, 2024
@DumboJetEngine
fix for opensearch-project#375
ab7fd4f 
Signed-off-by: Kostas <[email protected]>
@DumboJetEngine DumboJetEngine mentioned this issue Jan 8, 2024
Closed
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 8, 2024
@DumboJetEngine
fix for opensearch-project#375
84223d0 
Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 8, 2024
@DumboJetEngine
Fix for opensearch-project#375 - IEnumerable<int?> property serializa…
e60cc43 
…tion.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 8, 2024
@DumboJetEngine
Fix for opensearch-project#375 - IEnumerable<int?> property serializa…
a8052d6 
…tion.

Signed-off-by: Kostas <[email protected]>
@DumboJetEngine DumboJetEngine mentioned this issue Jan 8, 2024
Merged
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 11, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(bool) and `.Verbatim…
618f6fc 
…(bool)` methods on `QueryContainer` that recursively apply the respective attribute to all subqueries. Also added a `.Name(string)` method on `QueryContainer` that names the (root) contained query.

Signed-off-by: Kostas <[email protected]>
@DumboJetEngine DumboJetEngine mentioned this issue Jan 11, 2024
Merged
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 11, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(bool) and `.Verbatim…
08a873e 
…(bool)` methods on `QueryContainer` that recursively apply the respective attribute to all subqueries. Also added a `.Name(string)` method on `QueryContainer` that names the (root) contained query.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 11, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(bool) and `.Verbatim…
0ca18bc 
…(bool)` methods on `QueryContainer` that recursively apply the respective attribute to all subqueries. Also added a `.Name(string)` method on `QueryContainer` that names the (root) contained query.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 11, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(bool) and .Verbatim(bo…
6ba315a 
…ol) methods on QueryContainer that recursively apply the respective attribute to all subqueries. Also added a .Name(string) method on QueryContainer that names the (root) contained query.
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Jan 15, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(bool) and .Verbatim(bo…
fb53012 
…ol) methods on QueryContainer that recursively apply the respective attribute to all subqueries. Also added a .Name(string) method on QueryContainer that names the (root) contained query.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Feb 6, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(...), `.Verbatim(...…
88ab929 
…)`, `.Name(...)` methods on `QueryContainer` to help modify contained query attributes.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Feb 6, 2024
@DumboJetEngine
Fix for opensearch-project#375 - Added .Strict(...), `.Verbatim(...…
478d7e8 
…)`, `.Name(...)` methods on `QueryContainer` to help modify contained query attributes.

Signed-off-by: Kostas <[email protected]>
DumboJetEngine added a commit to DumboJetEngine/opensearch-net that referenced this issue Feb 6, 2024
@DumboJetEngine
On fix_375: Added .Strict(...), .Verbatim(...), .Name(...) meth…
6510ccb 
…ods on `QueryContainer` to help modify contained query attributes. (opensearch-project#375)

Signed-off-by: Kostas <[email protected]>
Xtansia pushed a commit that referenced this issue Feb 6, 2024
@DumboJetEngine
Added .Strict(...), .Verbatim(...), .Name(...) methods on `Quer…
e4f715e 
…yContainer` to help modify contained query attributes. (#375) (#509)

Signed-off-by: Kostas <[email protected]>
Xtansia pushed a commit to Xtansia/opensearch-net that referenced this issue Feb 6, 2024
@DumboJetEngine @Xtansia
Added .Strict(...), .Verbatim(...), .Name(...) methods on `Quer…
953f111 
…yContainer` to help modify contained query attributes. (opensearch-project#375) (opensearch-project#509)

Signed-off-by: Kostas <[email protected]>
(cherry picked from commit e4f715e)
dblock pushed a commit that referenced this issue Feb 7, 2024
@Xtansia @DumboJetEngine
Added .Strict(...), .Verbatim(...), .Name(...) methods on `Quer…
08ce783 
…yContainer` to help modify contained query attributes. (#375) (#509) (#539)

Signed-off-by: Kostas <[email protected]>
(cherry picked from commit e4f715e)

Co-authored-by: DumboJetEngine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xtansia @DumboJet