Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Groovy Parser correctly handle nested parenthesis #4801

Merged
merged 22 commits into from
Dec 19, 2024

Conversation

Laurens-W
Copy link
Contributor

What's changed?

Nested parentheses around method invocations are supported as well for the groovy parser.

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added bug Something isn't working parser-groovy labels Dec 19, 2024
@Laurens-W Laurens-W self-assigned this Dec 19, 2024
@jevanlingen
Copy link
Contributor

Very nice work, at last we have a working implementation!

@jevanlingen jevanlingen marked this pull request as ready for review December 19, 2024 16:28
@Laurens-W Laurens-W merged commit 91a031a into main Dec 19, 2024
2 checks passed
@Laurens-W Laurens-W deleted the groovy-parser-parenthesis-pt3 branch December 19, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser-groovy
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants