Allow file scheme in RemoteArchive
to simplify testing
#4791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it might look a bit controversial, the file scheme can also point to a remote (for instance a mounted network share) file. By allowing the
file://
scheme we can useRemoteArchive
for those files.As a useful side effect, this makes testing RemoteArchive handling a lot easier.
What's changed?
RemoteArchive
supportsfile://
protocolWhat's your motivation?
Make it easier to test without having to manipulate the context and mocking
Anything in particular you'd like reviewers to focus on?
Do we want to allow
file
protocol forRemoteArchive
Anyone you would like to review specifically?
@sambsnyd
Have you considered any alternatives or workarounds?
Manipulate the context and mock the webserver
Any additional context
less mocking, more better!
Checklist