Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file scheme in RemoteArchive to simplify testing #4791

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pstreef
Copy link
Contributor

@pstreef pstreef commented Dec 16, 2024

While it might look a bit controversial, the file scheme can also point to a remote (for instance a mounted network share) file. By allowing the file:// scheme we can use RemoteArchive for those files.

As a useful side effect, this makes testing RemoteArchive handling a lot easier.

What's changed?

RemoteArchive supports file:// protocol

What's your motivation?

Make it easier to test without having to manipulate the context and mocking

Anything in particular you'd like reviewers to focus on?

Do we want to allow file protocol for RemoteArchive

Anyone you would like to review specifically?

@sambsnyd

Have you considered any alternatives or workarounds?

Manipulate the context and mock the webserver

Any additional context

less mocking, more better!

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

While it might look a bit controversial, the file scheme can also point to a remote (for instance a mounted network share) file. By allowing the `file://` scheme we can use `RemoteArchive` for those files.

As a useful side effect, this makes testing RemoteArchive handling a lot easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant