MigrateHandlerInterceptor recipe migrates too much

[jevanlingen]

What's changed?

Improve/Bugfix the MigrateHandlerInterceptorrecipe to only migrate classes that directly extends the HandlerInterceptorAdapter.

What's your motivation?

Migration is targeted broadly, so it can migrate super calls when it is not intended to. This can lead to bugs, see

• fixes Custom HandlerInterceptor with Spring Boot 3 migration does not compile #620

for example.

Any additional context

The migration does now convert super.preHandle(..) to HandlerInterceptor.super.preHandle(..). According to mr unconditional, you should migrate to return true. See this SO post for more information.

Also this blog seems to suggest that this is the right move (as in, when you move from SB 2 to 3, you likely have a return true kind of implementation).

There are two other methods avaliable in the HandlerInterceptorAdapter/HandlerInterceptor classes: postHandle and afterCompletion. Both of them have empty default implementation, So maybe the recipe should be doing something else:

• preHandle: super.preHandle(..) -> return true
• postHandle: super.postHandle(..) -> <remove super call>
• afterCompletion: super.afterCompletion(..) -> <remove super call>

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files