Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new migration case of WebMvcConfigurer #616

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

SiBorea
Copy link
Contributor

@SiBorea SiBorea commented Nov 5, 2024

What's changed?

The origin recipe only handle classes that extend WebMvcConfigurer. In some cases, people return new WebMvcConfigurer() directly as a bean.

Checklist

  • [✅] I've added unit tests to cover both positive and negative cases
  • [✅] I've read and applied the recipe conventions and best practices
  • [✅] I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review November 5, 2024 09:52
@timtebeek timtebeek added the enhancement New feature or request label Nov 5, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these additional cases covered! Thanks a lot for the continued work on improvements here.

A quick question and two code suggestions before we merge, but otherwise this looks perfect already.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took out the ParameterizedType handling for now, as we're close to a release and didn't want your change to miss out on getting included. If needed we can fold that into the next release. Thanks again!

…MvcConfigurerAdapter.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@timtebeek timtebeek merged commit 132e79a into openrewrite:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants