Migrate AuditorAware to an Optional<> for spring boot 1 to 2 migration

[Jenson3210]

• This closes spring-data-commons changed AuditorAware from 1.x to 2.x #613

[Jenson3210]

@timtebeek I've added 4 //TODO Question for TIM:'s.
If you could have a look and help me out in understanding the issue? 🙏

Thanks!

[Jenson3210]

@timtebeek Can we also go over the changes of the bot once?
I am seeing stuff I would not perse just commit as suggestion.

For example: where did the maybeAddImport go?

[timtebeek]

@timtebeek Can we also go over the changes of the bot once? I am seeing stuff I would not perse just commit as suggestion.

For example: where did the maybeAddImport go?

Hi yes unfortunately the .patch file is correct, but once converted into comments by https://github.com/googleapis/code-suggester it's sometimes a little off when crossing multiple lines. I have yet to fix that external tool, or write my own.

You can also run the recipes directly if you prefer, possibly through the Moderne CLI to make it most convenient:
https://docs.openrewrite.org/recipes/recipes/openrewritebestpractices

[Jenson3210]

Okay. Makes sense.

On my private pc I do not have moderne cli set up yet as I do not have the access token etc.

Would that be possible for the open source projects (like open rewrite itself)?

[timtebeek]

Okay. Makes sense.

On my private pc I do not have moderne cli set up yet as I do not have the access token etc.

Would that be possible for the open source projects (like open rewrite itself)?

Yes for OSS you would not even need a Moderne license; Just a Moderne public instance personal access token to download recipes and LSTs.

[timtebeek]

Great to see how much of this you've covered already; I've applied some fixes already and left a few comments for other work left to do. Didn't quite finish the last failing test, but we can revisit that once the other items are crossed off.

[Jenson3210]

Hi @timtebeek ,

I've pushed some comments you made in the past 3 rounds of rewiew.
There are still 2 tests which I cannot get fixed with the Missing information:

• org.openrewrite.java.spring.data.MigrateAuditorAwareToOptionalTest#dontRewriteLambdaBlock
• org.openrewrite.java.spring.data.MigrateAuditorAwareToOptionalTest#dontRewriteLambdaLiteral

Strangly, both are in the don't -> lambda part. So it looks like the lambda in the test code can't be parsed.
The other negated entries are fine :/

[timtebeek]

Great to see! The last remaining failing tests were using a method signature from 2.x as opposed to 1.x, so changing the parser classpath for those tests while still asserting no change is made helped get those to pass.

There might be some scenarios not covered like a class defined in a separate file outside of an immediate return, but we can tackle those separately if they even occur in your wider scan there.

Thanks again!