Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate recipe to convert getStatus to getStatusCode with correct types #602

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

mslowiak
Copy link
Contributor

@mslowiak mslowiak commented Oct 10, 2024

What's changed?

Address migration of getStatus to getStatusCode with respecting type change from HttpStatus to HttpStatusCode.

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
    • lines 18-18
    • lines 31-33

@timtebeek timtebeek requested a review from Laurens-W October 11, 2024 08:07
@timtebeek timtebeek added enhancement New feature or request boot-3.0 labels Oct 11, 2024
@mslowiak mslowiak force-pushed the issue554-2 branch 2 times, most recently from 1291938 to 485b0ca Compare October 11, 2024 14:38
@mslowiak
Copy link
Contributor Author

@timtebeek @Laurens-W
Thanks for the tips, indeed it was a problem in visitVariableDeclarations - the variable in variableDeclarations.variables[0] had still HttpStatus inside variableType, name.type, name.fieldType 🚀

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
    • lines 18-18
    • lines 31-33

@mslowiak mslowiak marked this pull request as ready for review October 11, 2024 14:45
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
    • lines 18-18
    • lines 31-33

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
    • lines 18-18
    • lines 31-33

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see you've worked it out; Thanks a lot! Should help smooth out upgrade where the return type changed.

@timtebeek timtebeek merged commit 91b83bb into openrewrite:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.0 enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants