-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate recipe to convert getStatus to getStatusCode with correct types #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
- lines 18-18
- lines 31-33
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionTest.java
Show resolved
Hide resolved
1291938
to
485b0ca
Compare
@timtebeek @Laurens-W |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
- lines 18-18
- lines 31-33
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
- lines 18-18
- lines 31-33
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
...org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java
- lines 18-18
- lines 31-33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see you've worked it out; Thanks a lot! Should help smooth out upgrade where the return type changed.
What's changed?
Address migration of
getStatus
togetStatusCode
with respecting type change fromHttpStatus
toHttpStatusCode
.What's your motivation?
Checklist