-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JUnit4 SpringClassRule and SpringMethodRule to SpringExtension #571
Conversation
…ExtendWith(SpringExtension.class) or fares on an existing @SpringBootTest Solves #567
src/main/java/org/openrewrite/java/spring/test/SpringRulesToJUnitExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/test/SpringRulesToJUnitExtension.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/test/SpringRulesToJUnitExtensionTest.java
Outdated
Show resolved
Hide resolved
Regarding your concern with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition; thanks! Also thanks to @FieteO for the suggestion and helpful context in the review.
What's changed?
Added a recipe to migrate from JUnit 4 Spring Rules to JUnit 5 ExtendWith
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek @FieteO
Have you considered any alternatives or workarounds?
Any additional context
I'm wondering whether there'd be any harm in annotating the class with
@SpringBootTest
instead of@ExtendWith(SpringExtension.class)
Checklist