Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new reactor migration as of springboot 3.2 #564

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Laurens-W
Copy link
Contributor

Spring boot upgrade to 3.2.4 also upgrades io.projectreactor/reactor-bom from 2020.0.27 to 2023.0.4. This in turn upgrades reactor-core module from 3.4.26 to 3.6.5.

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Spring boot upgrade to 3.2.4 also upgrades io.projectreactor/reactor-bom from 2020.0.27 to 2023.0.4. This in turn upgrades reactor-core module from 3.4.26 to 3.6.5.
@Laurens-W Laurens-W self-assigned this Aug 12, 2024
@timtebeek timtebeek self-requested a review August 12, 2024 17:09
@timtebeek timtebeek marked this pull request as ready for review August 12, 2024 17:09
@timtebeek
Copy link
Contributor

Something odd is going on with the required versions here ; likely Spring Boot silently had a breaking version upgrade:
SB 3.1.0 came with Reactor BOM 2020.0.7, which manages reactor-core 3.4.6
https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.1.0/spring-boot-dependencies-3.1.0.pom
https://repo1.maven.org/maven2/io/projectreactor/reactor-bom/2020.0.7/reactor-bom-2020.0.7.pom

SB 3.1.12 came with Reactor BOM 2020.0.19, which manages reactor-core 3.5.17
https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.1.12/spring-boot-dependencies-3.1.12.pom
https://repo1.maven.org/maven2/io/projectreactor/reactor-bom/2022.0.19/reactor-bom-2022.0.19.pom

So in summary: the breaking change is already in 3.1.x, since we migrate folks to the latest in that range. I'll move accordingly.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Good not to miss these necessary steps going to 3.1+.

@timtebeek timtebeek merged commit e6f662c into main Aug 12, 2024
1 of 2 checks passed
@timtebeek timtebeek deleted the include-reactor-migration branch August 12, 2024 17:21
@timtebeek timtebeek added recipe Recipe requested boot-3.1 labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.1 recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants