Added Recipe for Migrating Dropwizard Dependencies #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
requested changes
Mar 20, 2024
|
Thanks @bsmahi ! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+41
to
+44
| import com.codahale.metrics.servlet.InstrumentedFilter; | ||
| import com.codahale.metrics.servlets.MetricsServlet; | ||
| """, | ||
| """ |
There was a problem hiding this comment.
Suggested change
| import com.codahale.metrics.servlet.InstrumentedFilter; | |
| import com.codahale.metrics.servlets.MetricsServlet; | |
| """, | |
| """ | |
| import com.codahale.metrics.servlet.InstrumentedFilter; | |
| import com.codahale.metrics.servlets.MetricsServlet; | |
| import io.dropwizard.metrics.servlet.InstrumentedFilter; | |
| import io.dropwizard.metrics.servlets.MetricsServlet; |
| oldGroupId: io.dropwizard.metrics | ||
| oldArtifactId: metrics-servlet | ||
| newArtifactId: metrics-jakarta-servlet | ||
| newVersion: 4.2.xx |
There was a problem hiding this comment.
I don't think I've seen xx in a version selector before. I think it would probably better as just x unless I am missing something here.
There was a problem hiding this comment.
@knutwannheden in the maven central, dropwizard version being specified in the format of 4.2.23 hence have given format as 4.2.xx.
Please suggest.
I am happy to change, please create issue and assigned to me, I will work on it.
Thanks,
Mahi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added Recipe for migrating dropwizard dependencies to spring boot 3.x
What's your motivation?
I would love explore and contribute more on open-source and for openrewrite framework
Anyone you would like to review specifically?
@timtebeek Could you please review it. Thanks.
Checklist