Boot 3 upgrade doesn't add XML Bind dependency #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/testWithSpringBoot_2_7/java/org/openrewrite/java/spring/boot2/Boot3UpgradeTest.java
Outdated
Show resolved
Hide resolved
…ot2/Boot3UpgradeTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/testWithSpringBoot_2_7/java/org/openrewrite/java/spring/boot2/Boot3UpgradeTest.java
Outdated
Show resolved
Hide resolved
…ot2/Boot3UpgradeTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/testWithSpringBoot_2_7/java/org/openrewrite/java/spring/boot2/Boot3UpgradeTest.java
Outdated
Show resolved
Hide resolved
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.gradle.UpdateGradleWrapper?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
As indicated on openrewrite#517 (comment)
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.BlankLinesAroundFieldsWithAnnotations?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/kLJjXlflM?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
src/testWithSpringBoot_2_7/java/org/openrewrite/java/spring/boot2/Boot3UpgradeTest.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Jun 20, 2024
|
Locally I've found the test to still fail with the following, but we'll get a second opinion from CI just to be sure diff --git a/project/pom.xml b/project/pom.xml
index 4369491..f80ac0a 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -30,10 +30,6 @@
<artifactId>jakarta.validation-api</artifactId>
</dependency>
<dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- </dependency>
- <dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-data-jpa</artifactId>
</dependency> |
|
Ok CI passes; that's an improvement! I'll see about polishing this up for addition to your tests then, and figure out what's troubling locally. :) |
timtebeek
approved these changes
Jun 20, 2024
|
If I understood this comment correctly we should remove the expected added dependency here again I'll go ahead and try that here. |
|
Thanks again @BoykoAlex ! Really great not to have those unnecessary dependencies added, and good to have a comprehensive test to guard that going forward. |
|
@timtebeek Thanks a lot for merging all those PRs so quickly!!! |
|
Of course! Really appreciated how you dove deep to get very targeted fixes with great effects downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test demonstrating an issue upgrading Petclinic to Boot 3.
jakarta.xml.bind-apidependency should be added explicitly but it's not becauserewrite-mavendependency resolution thinks that this dependency is present on the compile scope already for some reason via transitive dependencies.