New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issues related to new addProperty signature #457

Merged

timtebeek merged 1 commit into openrewrite:main from SimonVerhoeven:feat/resolveBuild

Dec 6, 2023

Contributor

SimonVerhoeven commented Dec 6, 2023

What's changed?

Resolved build issues related to new addProperty signature

What's your motivation?

to resolve build issues

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

I've added unit tests to cover both positive and negative cases
I've read and applied the recipe conventions and best practices
I've used the IntelliJ IDEA auto-formatter on affected files


          fix: fix issues related to new addProperty signature

5ce5ba3

timtebeek merged commit 4dccb9d into openrewrite:main

1 check passed

Contributor

timtebeek commented Dec 6, 2023

Thanks a lot! Indeed a downstream effect of

AddProperty now accepts a comment rewrite#3771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet