Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mesh material homogenization to include or exclude voids #3000

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

paulromano
Copy link
Contributor

Description

This PR adds an include_void argument to Mesh.get_homogenized_materials. The default is True, which means that homogenization will account for voids (they will effectively increase the volume and decrease the density of homogenized materials). If it is False, voids will be ignored and won't impact the density of the mixture of materials.

To speak to the motivation, I found this to be necessary for a mesh-based R2S workflow where I was only sourcing decay photons in material (using domain rejection to avoid any voids).

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @paulromano

@pshriwise pshriwise merged commit 88f3e4d into openmc-dev:develop Jun 10, 2024
18 checks passed
@paulromano paulromano deleted the mesh-homogenize-void branch June 10, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants