Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recenter map on overview map click #15963

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Jul 2, 2024

This pull request changes the behavior of the overview map. Previously, only dragging the box overlay re-centered the main map. Now, the map is also re-centered to any point clicked on the overview map.

@ahocevar ahocevar marked this pull request as ready for review July 2, 2024 17:24
@ahocevar ahocevar force-pushed the overviewmap-click branch from 0e26cf1 to 11ce517 Compare July 2, 2024 19:39
@ahocevar
Copy link
Member Author

ahocevar commented Jul 2, 2024

Added tests and converted OverviewMap from mouse to pointer events.

@ahocevar ahocevar changed the title Reenter map on overview map click Recenter map on overview map click Jul 3, 2024
@ahocevar ahocevar force-pushed the overviewmap-click branch from 11ce517 to 62a1a1c Compare July 3, 2024 07:19
@ahocevar
Copy link
Member Author

ahocevar commented Jul 3, 2024

Fixed typo in commit message.

@ahocevar
Copy link
Member Author

ahocevar commented Jul 4, 2024

@marcjansen, maybe this is something you'd enjoy reviewing?

@ahocevar
Copy link
Member Author

ahocevar commented Jul 5, 2024

Or @jahow @fredj, you also haven't reviewed pull requests in quite a while. How about this simple one to get back into the habit?

Copy link
Contributor

@MoonE MoonE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahocevar

@ahocevar
Copy link
Member Author

ahocevar commented Jul 7, 2024

Thanks for the review, @MoonE!

@ahocevar ahocevar merged commit 77cafa3 into openlayers:main Jul 7, 2024
8 checks passed
@ahocevar ahocevar deleted the overviewmap-click branch July 7, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants