-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spacechem as an humblebundle game #18
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, after switching to buildGame
I'll merge :-)
@aszlig I fixed according to your comments. I had troubles with {setS,s}ourceRoot and fixed some code in buildGame. I am also not too sure about coreutils and uname invocations made by the game. If this is ok, do not forget to autosquash before merging. |
@aszlig Wanna have a second look at this one ? |
Updated, as a new fixed version was released in the meantime. |
Oh, BTW, the humblebundle downloader does not work anymore. Not sure if this is really important, especially given that the upstream python lib has not been updated since 2015. |
@layus: Hm, one question remains though: You haven't set a sandbox path, so I'd assume the game writes save files in |
@layus: Regarding the HB downloader, I'm already aware of that and will fix it along with the merge of your PRs. |
Updated the sandbox path. There is a strange access to a pulse "cookie" in CONFIG_HOME/pulse. It gets created by spacechem, but it needs write permission there. |
@layus: While this is just an ugly thing that's not a stopper for merging this PR, can you post a |
Here it is https://gist.github.com/dab849ee90e7384b45616c07379064e0 :-). I grep'd 'layus' for brevity. |
and the same, when "$XDG_CONFIG_HOME/pulse" is removed from the required sandbox paths: https://gist.github.com/3fb6dcb1de51a351d3ee16f49894a5aa |
https://www.reddit.com/r/spacechem/comments/1qundh/fully_functional_spacechem_on_linux/ has interesting remarks. I have no idea what xclip is for. never encountered the bug. |
@layus: Regarding the pulse cookie, this might be also due to a mixture of 32/64 bit libraries as well, because usually the pulse cookie should be gathered via the X session, but for some reason not included in the strace (as it's only |
I guess Spacechem is calling |
It is a .exe (admitedly, ad 32bit .exe) that runs with mono. It works perfectly well with a 64 bit mono, so I do not get the point of downloading all the 32 bit version of all the dependencies just to autoPatchelfHook patch rgb2theora correctly. |
It looks like it is working properly with 32bits. |
I could not find the source that calls xclip, but adding it to path fixes the issue. It's good enough for now. Also removed the "cookie" sandbox path. Seems not needed for sound to play. |
No description provided.