Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GOVERNANCE.md #1134

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Update GOVERNANCE.md #1134

merged 3 commits into from
Oct 24, 2023

Conversation

jasuarez90
Copy link
Contributor

Updated instructions for onboarding regular members. (Note: This is my first time doing a pull request)

@jasuarez90
Update GOVERNANCE.md
6ac35d0 
Updated instructions for onboarding regular members. 

Signed-off-by: Julian Suarez <[email protected]>
@jasuarez90 jasuarez90 requested a review from a team as a code owner August 7, 2023 19:50
@joesepi
Copy link
Member

joesepi commented Aug 7, 2023

I wonder if this sort of process work should even be in the GOVERNANCE.md file.

ljharb
ljharb approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, but it should be moved in a separate PR

ljharb
ljharb requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[OpenJS Foundation CPC directory][] is now unused, is that intentional? If so, please remove the definition.

governance/GOVERNANCE.md Outdated Show resolved Hide resolved
tobie and others added 2 commits August 8, 2023 23:32
@tobie @ljharb
Fix typo
e742f92 
Co-authored-by: Jordan Harband <[email protected]>
Signed-off-by: Tobie Langel <[email protected]>
@joesepi
removing abandoned link reference
4ffa611 
Signed-off-by: Joe Sepi <[email protected]>
mhdawson
mhdawson approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joesepi joesepi merged commit 8f76b04 into main Oct 24, 2023
2 checks passed
@joesepi joesepi deleted the jasuarez90-patch-1 branch October 24, 2023 19:01
bensternthal pushed a commit to bensternthal/cross-project-council that referenced this pull request Apr 23, 2024
@jasuarez90 @tobie
@ljharb @joesepi @bensternthal
Update GOVERNANCE.md (openjs-foundation#1134)
c107cdf 
* Update GOVERNANCE.md

Updated instructions for onboarding regular members. 

Signed-off-by: Julian Suarez <[email protected]>

* Fix typo

Co-authored-by: Jordan Harband <[email protected]>
Signed-off-by: Tobie Langel <[email protected]>

* removing abandoned link reference

Signed-off-by: Joe Sepi <[email protected]>

---------

Signed-off-by: Julian Suarez <[email protected]>
Signed-off-by: Tobie Langel <[email protected]>
Signed-off-by: Joe Sepi <[email protected]>
Co-authored-by: Tobie Langel <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Joe Sepi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@anonrig anonrig anonrig approved these changes

@joesepi joesepi joesepi approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasuarez90 @joesepi @ljharb @anonrig @mhdawson @tobie