-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patching script for CoC modifications #910
Comments
Absent an exemplar to follow, I envision a custom script that works in this way:
|
It looks like this issue has been on the agenda multiple times. The Contributor Covenant CoC is updated VERY rarely. In the event it's updated, such as a major version, it doesn't feel likely that the patch would work. If there's a structural change, the diff isn't going to be applied well. If the answer is, "OK, then we need a new patch at that point in time," I think that's OK, but it feels like overhead. |
Every time it's come up, the sense has seemed to be that we need #910 (comment) next. |
@ljharb, I think Ben has a point: if we're blocking on a technical implementation that's currently for a one-line diff, maybe we should reconsider building tooling for this, and instead do it manually, at least for now. |
@tobie oh sure, i wasn't disagreeing with the point, i was just reiterating past consensus. |
As discussed in #909, and requested in #851, we'd like to add a patch file for the CoC and a script to automate patching updates. Both should be versioned.
Pointers on best practices to do that are welcomed.
The text was updated successfully, but these errors were encountered: