Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating bootrom for 32b #723

Merged
merged 1 commit into from
Sep 8, 2021
Merged

updating bootrom for 32b #723

merged 1 commit into from
Sep 8, 2021

Conversation

sjthales
Copy link
Contributor

@sjthales sjthales commented Sep 7, 2021 •
edited
Loading

Verified with Linux 64 bits and Linux 32 bits

@sjthales sjthales requested a review from zarubaf as a code owner September 7, 2021 10:03
zarubaf
zarubaf approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Jbalkind had some concerns regarding OP, are they addressed?

@sjthales
Copy link
Contributor Author

sjthales commented Sep 7, 2021 •
edited
Loading

Actually, All I modified regards the FPGA implementation on Genesys board. According to me that changes nothing for OP.

@zarubaf zarubaf merged commit f5cbaa9 into openhwgroup:master Sep 8, 2021
@Jbalkind
Copy link
Contributor

Jbalkind commented Sep 10, 2021 •
edited
Loading

That's not true. This breaks our build because files were moved/renamed. openpiton/bootrom/baremetal has multiple symlinks into bootrom/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarubaf zarubaf zarubaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjthales @Jbalkind @zarubaf