Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Comment]: ID for compressed_req #230

Open
AyoubJalali opened this issue Dec 2, 2024 · 1 comment
Open

[Review Comment]: ID for compressed_req #230

AyoubJalali opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
public-review Issues during public review

Comments

@AyoubJalali
Copy link

Comment

Hello I am working on the verification of CVA6, specifically on re-verifying the CVXIF interface after changing the specification. I have a couple of questions:

For the compressed interface, is it acceptable that the compressed_req does not have an ID field to specify the compressed transaction? The compressed response packet refers to an ID, but we currently don’t have one.
in the last version of the spec we had ID for compressed interface.

Regarding the commit interface, the specification mentions that commit_valid cannot be asserted for two clock cycles. Does this restriction apply to the same ID only, or is it also valid for back-to-back instructions with different IDs ? this was refers in #229

Thank you for your insights !

Proposed Resolution

Precise why we don't have ID for compressed interface ? is it useless in the version of the spec or in the implementation ?

Addition Info

No response

@AyoubJalali AyoubJalali added the public-review Issues during public review label Dec 2, 2024
@AyoubJalali
Copy link
Author

In a verification point of view, the lack of a unique identifier in the compressed_req transactions presents a significant challenge for monitoring and checking. Without an ID field or another distinguishing feature, the monitor cannot reliably differentiate between back-to-back transactions, especially if the compressed_valid signal remains high or if consecutive transactions have identical instr values. This ambiguity complicates transaction tracking, making it difficult to associate requests with their corresponding responses and to detect issues such as dropped or duplicated transactions. To ensure robust verification, it is crucial to incorporate a mechanism, such as a unique transaction ID, to unambiguously identify each request. This enhances the monitor's ability to match transactions, improves debug capabilities, and ensures accurate coverage metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public-review Issues during public review
Projects
None yet
Development

No branches or pull requests

2 participants