Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Comment]: Precision regarding commit_valid only 1 cycle. #229

Open
Gchauvon opened this issue Nov 25, 2024 · 0 comments
Open

[Review Comment]: Precision regarding commit_valid only 1 cycle. #229

Gchauvon opened this issue Nov 25, 2024 · 0 comments
Labels
public-review Issues during public review

Comments

@Gchauvon
Copy link

Gchauvon commented Nov 25, 2024

Comment

The commit_valid signal will be 1 exactly one clk cycle. It is not required that a commit transaction is performed for
each offloaded instruction individually. Instructions can be signalled to be non-speculative or to be killed in batch.

Regarding this point of the specification:
Does it mean commit_valid can not be asserted for 2 clk cycles in a row if 2 issue transaction with different ids happens in a row ?

I believe it is a scenario that should be allowed especially for non-speculative CPU. Even though we can "commit" in batch, we should be able to not to do it and "commit" for each issue transaction.

Proposed Resolution

Precise that we can have a commit transaction for each issue transaction

Addition Info

No response

@Gchauvon Gchauvon added the public-review Issues during public review label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public-review Issues during public review
Projects
None yet
Development

No branches or pull requests

1 participant