Added behavior discussed in Issue 2123 for USE_ISS #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to launch the really last non-regression... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not find anywhere in any up-to-date
cv32e40s/dev,cv32e40x/devandmasterwhat you told me in #2123, so I added my own version, don't hesitate to discard the PR if I missed it or I didn't search in the right place.The modification will simply check if USE_ISS have been given as an argument to the make command, and if not, it will decide to update USE_ISS to YES or NO depending on the definition or not of the IMPERAS_HOME variable.
As a bonus, an info message telling the user what's going on.
I found USE_ISS definition in two files, I don't remember using core.mk during the last months, but I copy and paste the code from uvmt.mk anyway.