-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting started guide, example script #68
Conversation
mattwthompson
commented
Oct 11, 2024
•
edited
Loading
edited
- Update "getting started" section
- Add bit about grabbing data from QCSubmit
- Add usage examples
- Get molecule identifiers
- Inspect QM and MM structures
- Manually compute DDE
Co-authored-by: Lexie McIsaac <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall. I added some suggested fixes to very minor typos but otherwise happy to approve. I think the model_validate_json
question I marked is the only potentially-functional issue, but if the script runs then it's clearly not a problem.
Co-authored-by: Brent Westbrook <[email protected]>
Thanks for the review @ntBre! I will try to finish this up later today |