Upgrade Jenkins Node version to 8.9.3 #16680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arizzitano
force-pushed
the
ari/node-8
branch
2 times, most recently
from
c996297 to
9e6ea56
Compare
arizzitano
changed the title
arizzitano
force-pushed
the
ari/node-8
branch
from
0eda4e1 to
654c5be
Compare
|
jenkins run js |
bump node version to 8.9.3 [FEDX-409] bump node version to 8.9.1 [FEDX-409] 8.9.3 don't clean cache try ignoring course_experience another attempt back out that coverage patch
arizzitano
force-pushed
the
ari/node-8
branch
from
98d738c to
2ca0aa7
Compare
arizzitano
changed the title
ormsbee
reviewed
Jan 22, 2018
| # Manage the npm cache on Jenkins. | ||
| # (In this case, remove it. That ensures from run-to-run, it is a clean npm environment) | ||
| echo "--> Cleaning npm cache" | ||
| npm cache clean |
There was a problem hiding this comment.
Shouldn't hold up the PR, but I'm curious -- why was this part removed?
There was a problem hiding this comment.
As of npm 5, it exits nonzero unless you use --force, since supposedly now the npm cache is self-healing. npm cache verify works similarly, but it might be a better idea for us to just force the clean and wipe it out entirely -- what do you think @ormsbee?
There was a problem hiding this comment.
Thanks for the explanation. I think it's fine to leave it as you already have it here. If it turns out to be problematic, we can always adjust later.
ormsbee
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://github.com/edx/configuration/pull/4219.