Footer configuration changes #2042
Conversation
| EDXAPP_PLATFORM_TWITTER_URL: "https://twitter.com/YourPlatformTwitterAccount" | ||
| EDXAPP_PLATFORM_MEETUP_URL: "http://www.meetup.com/YourMeetup" | ||
| EDXAPP_PLATFORM_LINKEDIN_URL: "http://www.linkedin.com/company/YourPlatform" | ||
| EDXAPP_PLATFORM_GOOGLE_PLUS_URL: "https://plus.google.com/YourGooglePlusAccount/" |
There was a problem hiding this comment.
These haven't been used in production for months now, so I'm removing them. These aren't used by open source installations (unless they've explicitly enabled the edx.org footer), so this should be low-risk to remove.
There was a problem hiding this comment.
I would still add a changelog entry since they are ALL_CAPS vars which means they are part of the list of items we expect people to be able to configure.
|
@wedaly please update the changelog to indicate that this change is backwards incompatible since it will break people who might be running older versions of edx platform. Please include the link to the edx-platform PR in the changelog as well. There will also need to be an update to our config-secure for this change, please link to the ticket for that work here when you've created it. |
* Expose mobile store URLs setting to edxapp role. * Remove deprecated social media URLs.
wedaly
force-pushed
the
will/footer-configuration-updates
branch
from
2accfb8 to
a032d91
Compare
|
@feanil Updated the changelog and created https://openedx.atlassian.net/browse/DEVOPS-1912 with the updates to config-secure. |
|
👍 |
The related PR is: https://github.com/edx/edx-platform/pull/8175.
@feanil please review.