Docker.ubi: add missing package git #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the Dockerfile.ubi to add a package needed by the binarry build of the cuda kernels.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: z103cb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
z103cb
requested review from
Xaenalt,
dtrifiro and
heyselbi
and removed request for
terrytangyuan and
vaibhavjainwiz
|
/lgtm |
openshift-merge-bot
bot
merged commit 38eed8a
into
opendatahub-io:ibm_main
3 checks passed
Merged
|
We added this to have the cutlass build work, but we have issues detecting the cutlass revision: |
dtrifiro
pushed a commit
that referenced
this pull request
Jun 18, 2024
Within the existing `decoding` request parameter section:
```protobuf
enum ResponseFormat {
// Plain text, no constraints
TEXT = 0;
// Valid json
JSON = 1;
}
message StringChoices {
repeated string choices = 1;
}
// Mutually-exclusive guided decoding options
oneof guided {
// Output will be in the specified format
ResponseFormat format = 3;
// Output will follow the provided JSON schema
string json_schema = 4;
// Output will follow the provided regex pattern
string regex = 5;
// Output will be exactly one of the specified choices
StringChoices choice = 6;
// Output will follow the provided context free grammar
string grammar = 7;
}
```
Signed-off-by: Nick Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the Dockerfile.ubi to add a package needed by the binary build of the cuda kernels.