-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROP: Upgrade go version to 1.22.2 #20
DROP: Upgrade go version to 1.22.2 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a solution in place to update downstream builds already?
@astefanutti working on that atm. Planning on using the same strategy performed for Kueue: https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/2315/diffs However, I think I'm having an issue with building this odh/kuberay image with go 1.22.2, saying formatting should be 1.22. Checking if this is just my local environment. I think we shouldn't go below
|
d00b95e
to
51e76a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good overall, just a couple of questions:
- Why 1.22.2 and not 1.22.3?
- Should it be a DROP instead of a PATCH?
51e76a1
to
c86865c
Compare
|
@ChristianZaccaria Thanks. |
Why are these changes needed?
net/http
from the Go standard library in versions below 1.21.9 and below 1.22.2.rhoai-2.8
,rhoai-2.10
, andrhoai-2.11
.Related issue number
Jira: rhoai-2.8 https://issues.redhat.com/browse/RHOAIENG-8674
Jira: rhoai-2.10 https://issues.redhat.com/browse/RHOAIENG-8624
Jira: rhoai-2.11 https://issues.redhat.com/browse/RHOAIENG-8657
CPaaS
2.10: https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/2343
2.8: will do after confirmation
2.11: will do after confirmation
Checks