Sync changes from the rhds/old-main branch that Rishab created, so we can delete that branch #485
Conversation
Sync upstream for RHODS-1.26
This allows updating the notebook controllers without increasing the resources requirements of ODH during the update, which means it can better tolerates situation such as the cluster being full. This means the notebook controller will be unavailable during the update. However, this has not visible consequences except for a slight delay in the notebooks CR reconciliation, until the new controller pod start reconciling.
Sync main branch with odh v1.6-branch
add renovate config
remove renovate config
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiridanek
changed the title
|
This The current |
|
/cc @harshad16 |
| @@ -10,6 +10,10 @@ kind: Deployment | |||
| metadata: | |||
| name: deployment | |||
| spec: | |||
| strategy: | |||
There was a problem hiding this comment.
That spec.strategy option is already included on the managers' deployment files in both branches main and v1.9-branch
| @@ -6,6 +6,10 @@ metadata: | |||
| namespace: system | |||
| spec: | |||
| replicas: 1 | |||
| strategy: | |||
There was a problem hiding this comment.
|
@atheo89 thanks! I trusted the gh diff too much, thought that when it shows these lines as addition, they have to be new. |
I don't understand what it does. Do we want it? Maybe we should just delete old-main without merging it.
The description on the original commit was
I guess it's quite plausible it has that effect. Do we still want it?