Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA-12137636266] Update odh and notebook-controller with image 1.9-343990c - Testing PR #482

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 3, 2024

🤖 This is an automated Pull Request created by /.github/workflows/notebook-controller-images-updater.yaml.

Have been updated the following related files:

  • components/notebook-controller/config/overlays/openshift/params.env
  • components/odh-notebook-controller/config/base/params.env
  • components/odh-notebook-controller/makefile-vars.mk

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant December 3, 2024 10:23
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 3, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89 atheo89 changed the title [GHA-12137636266] Update odh and notebook-controller with image 1.9-343990c [GHA-12137636266] Update odh and notebook-controller with image 1.9-343990c - Testing PR Dec 3, 2024
@atheo89 atheo89 mentioned this pull request Dec 3, 2024
3 tasks
@atheo89 atheo89 closed this Dec 3, 2024
@atheo89 atheo89 reopened this Dec 3, 2024
@atheo89
Copy link
Member

atheo89 commented Dec 3, 2024

Closing this as the verification pass

@atheo89 atheo89 closed this Dec 3, 2024
@jiridanek jiridanek deleted the temp-v1.9-branch-12137636266 branch December 3, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant